Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable installation_iojs test suit in GitHub Actions #3476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwagantall
Copy link

No description provided.

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Nov 21, 2024
@jwagantall
Copy link
Author

@ljharb , looks like this test suit is passing without issues, except for the v0.40.0 tests that have been failing for a while in production.

Is there anyone looking into those?

@ljharb
Copy link
Member

ljharb commented Nov 21, 2024

Those are expected to fail forever, since v0.40.0 won't ever have the bug fixed.

@jwagantall
Copy link
Author

Those are expected to fail forever, since v0.40.0 won't ever have the bug fixed.

Thank you!

On regards to the Travis failure: https://app.travis-ci.com/github/nvm-sh/nvm/jobs/628361855

Looks like this failure is the same than the one I just started seeing in the slow test suits. It just started happening and is not an issue with the node version since the same stable version was passing a week before..

I'm gonna continue looking and see if this is something related to anything else.. :(

@ljharb
Copy link
Member

ljharb commented Nov 21, 2024

I think it's a legit failure in both suites, though - these tests talk to the network and the registry and can have their results change over time, legitimately.

Remove equivalent TravisCI entries

Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
@jwagantall
Copy link
Author

I think it's a legit failure in both suites, though - these tests talk to the network and the registry and can have their results change over time, legitimately.

Actually, I was looking into them a little more and these are indeed legitimate failures I started seeing today in the slow test suit.

Even if this change is meant for "installation_iojs", so we need to make sure the slow tests are passing in TravisCI before we could merge this change?

@ljharb
Copy link
Member

ljharb commented Nov 22, 2024

It would be ideal for maximum confidence to have them passing in travis as well, yes, if only to figure out the cause of the failure conclusively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants